-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Switch to viper for configuration #70
Conversation
Phylum OSS Supply Chain Risk Analysis - FAILEDThis repository analyzes the risk of new dependencies. An If you see this comment, one or more dependencies have failed Phylum's risk analysis. Package:
|
Codecov Report
@@ Coverage Diff @@
## main #70 +/- ##
==========================================
+ Coverage 50.39% 52.99% +2.60%
==========================================
Files 13 13
Lines 512 568 +56
==========================================
+ Hits 258 301 +43
- Misses 252 261 +9
- Partials 2 6 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Phylum OSS Supply Chain Risk Analysis - SUCCESSThe Phylum risk analysis is complete and has passed the active policy. |
7d03d48
to
d5129e8
Compare
@tarkatronic packages excluded 😊 |
Beautiful, thank you! Hmmm looks like now
It looks like in both of those cases you are not capturing the return value of the function. That's especially problematic in the first instance, as your are attempting an error check, from a previous error value! |
Strange, I definitely hit "Cancel" on that review just now. Ignore all that... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a great starting point for this switch -- this unlocks so many more possibilities for configuration! Thanks for tackling this @JoseAngel1196!
Task
Fixes #32
Description